NULL needs to be cast to void * when passed to a variadic function like

execl().  Spotted by Damien Miller.

[originally from svn r5592]

diff --git a/unix/uxproxy.c b/unix/uxproxy.c
index 617f5ccf07d04b7a23ec985aab63bde0e88822b3..209991fc8ee6387fe2a1d2fa512b4b0b05d3d390 100644 (file)
--- a/unix/uxproxy.c
+++ b/unix/uxproxy.c
@@ -281,7 +281,7 @@ Socket platform_new_connection(SockAddr addr, char *hostname,
            close(i);
        fcntl(0, F_SETFD, 0);
        fcntl(1, F_SETFD, 0);
-       execl("/bin/sh", "sh", "-c", cmd, NULL);
+       execl("/bin/sh", "sh", "-c", cmd, (void *)NULL);
        _exit(255);
     }
 

diff --git a/unix/uxpty.c b/unix/uxpty.c
index f91dc7160ead071a18014f7d7ebc6ddee007f875..37a017d35ad79f8b19afdca765ef6caedbe628c3 100644 (file)
--- a/unix/uxpty.c
+++ b/unix/uxpty.c
@@ -813,7 +813,7 @@ static const char *pty_init(void *frontend, void **backend_handle, Config *cfg,
                sprintf(shellname, "-%s", p);
            } else
                shellname = shell;
-           execl(getenv("SHELL"), shellname, NULL);
+           execl(getenv("SHELL"), shellname, (void *)NULL);
        }
 
        /*