crypto: cavium/nitrox - no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Srikanth Jampala <Jampala.Srikanth@cavium.com>
Cc: Yangtao Li <tiny.windzz@gmail.com>
Cc: Gadam Sreerama <sgadam@cavium.com>
Cc: Eric Biggers <ebiggers@google.com>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/cavium/nitrox/nitrox_debugfs.c b/drivers/crypto/cavium/nitrox/nitrox_debugfs.c
index 0196b992280f7eb7d82dfd6153f4d522dc814fc1..848ec93d4333d0bb04bd89c78f1616a27d4407c0 100644 (file)
--- a/drivers/crypto/cavium/nitrox/nitrox_debugfs.c
+++ b/drivers/crypto/cavium/nitrox/nitrox_debugfs.c
@@ -55,31 +55,14 @@ void nitrox_debugfs_exit(struct nitrox_device *ndev)
        ndev->debugfs_dir = NULL;
 }
 
-int nitrox_debugfs_init(struct nitrox_device *ndev)
+void nitrox_debugfs_init(struct nitrox_device *ndev)
 {
-       struct dentry *dir, *f;
+       struct dentry *dir;
 
        dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
-       if (!dir)
-               return -ENOMEM;
 
        ndev->debugfs_dir = dir;
-       f = debugfs_create_file("firmware", 0400, dir, ndev,
-                               &firmware_fops);
-       if (!f)
-               goto err;
-       f = debugfs_create_file("device", 0400, dir, ndev,
-                               &device_fops);
-       if (!f)
-               goto err;
-       f = debugfs_create_file("stats", 0400, dir, ndev,
-                               &stats_fops);
-       if (!f)
-               goto err;
-
-       return 0;
-
-err:
-       nitrox_debugfs_exit(ndev);
-       return -ENODEV;
+       debugfs_create_file("firmware", 0400, dir, ndev, &firmware_fops);
+       debugfs_create_file("device", 0400, dir, ndev, &device_fops);
+       debugfs_create_file("stats", 0400, dir, ndev, &stats_fops);
 }

diff --git a/drivers/crypto/cavium/nitrox/nitrox_debugfs.h b/drivers/crypto/cavium/nitrox/nitrox_debugfs.h
index a8d85ffa619ca4dd1a784cff2d282e5947342158..f177b79bbab04798ff1868c701c5c24dd1c1029c 100644 (file)
--- a/drivers/crypto/cavium/nitrox/nitrox_debugfs.h
+++ b/drivers/crypto/cavium/nitrox/nitrox_debugfs.h
@@ -5,12 +5,11 @@
 #include "nitrox_dev.h"
 
 #ifdef CONFIG_DEBUG_FS
-int nitrox_debugfs_init(struct nitrox_device *ndev);
+void nitrox_debugfs_init(struct nitrox_device *ndev);
 void nitrox_debugfs_exit(struct nitrox_device *ndev);
 #else
-static inline int nitrox_debugfs_init(struct nitrox_device *ndev)
+static inline void nitrox_debugfs_init(struct nitrox_device *ndev)
 {
-       return 0;
 }
 
 static inline void nitrox_debugfs_exit(struct nitrox_device *ndev)

diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c
index 014e9863c20e2d4143249c53a52ae6cf49e38729..faa78f65123816d30c88a61b8b005ada7f8cc8d3 100644 (file)
--- a/drivers/crypto/cavium/nitrox/nitrox_main.c
+++ b/drivers/crypto/cavium/nitrox/nitrox_main.c
@@ -404,9 +404,7 @@ static int nitrox_probe(struct pci_dev *pdev,
        if (err)
                goto pf_hw_fail;
 
-       err = nitrox_debugfs_init(ndev);
-       if (err)
-               goto pf_hw_fail;
+       nitrox_debugfs_init(ndev);
 
        /* clear the statistics */
        atomic64_set(&ndev->stats.posted, 0);