]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
fs: fat: Eliminate timespec64_trunc() usage
authorDeepa Dinamani <deepa.kernel@gmail.com>
Tue, 3 Dec 2019 05:19:40 +0000 (21:19 -0800)
committerAl Viro <viro@zeniv.linux.org.uk>
Mon, 9 Dec 2019 00:10:51 +0000 (19:10 -0500)
timespec64_trunc() is being deleted.

timestamp_truncate() is the replacement api for
timespec64_trunc. timestamp_truncate() additionally clamps
timestamps to make sure the timestamps lie within the
permitted range for the filesystem.

But, fat always truncates the times locally after it obtains
the timestamps from current_time().
Implement a local version here along the lines of existing
truncate functions.

Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: hirofumi@mail.parknet.co.jp
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/fat/misc.c

index 1e08bd54c5fbe599ba039ad668ff4cdc392b63b7..f1b2a1fc2a6a42b8f802268a8d6c071ff2d25530 100644 (file)
@@ -271,6 +271,14 @@ static inline struct timespec64 fat_timespec64_trunc_2secs(struct timespec64 ts)
 {
        return (struct timespec64){ ts.tv_sec & ~1ULL, 0 };
 }
+
+static inline struct timespec64 fat_timespec64_trunc_10ms(struct timespec64 ts)
+{
+       if (ts.tv_nsec)
+               ts.tv_nsec -= ts.tv_nsec % 10000000UL;
+       return ts;
+}
+
 /*
  * truncate the various times with appropriate granularity:
  *   root inode:
@@ -308,7 +316,7 @@ int fat_truncate_time(struct inode *inode, struct timespec64 *now, int flags)
        }
        if (flags & S_CTIME) {
                if (sbi->options.isvfat)
-                       inode->i_ctime = timespec64_trunc(*now, 10000000);
+                       inode->i_ctime = fat_timespec64_trunc_10ms(*now);
                else
                        inode->i_ctime = fat_timespec64_trunc_2secs(*now);
        }