]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
pinctrl: rockchip: Delete error messages for a failed memory allocation in two functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 23 Dec 2017 21:02:47 +0000 (22:02 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 3 Jan 2018 07:46:50 +0000 (08:46 +0100)
Omit extra messages for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-rockchip.c

index 073de6a9ed34f2d5091abff46b4d5d528029c08c..fd1f363a8c2b8a89c5904ce5c2cc93e2805c159b 100644 (file)
@@ -2408,18 +2408,14 @@ static int rockchip_pinctrl_parse_dt(struct platform_device *pdev,
        info->functions = devm_kzalloc(dev, info->nfunctions *
                                              sizeof(struct rockchip_pmx_func),
                                              GFP_KERNEL);
-       if (!info->functions) {
-               dev_err(dev, "failed to allocate memory for function list\n");
+       if (!info->functions)
                return -EINVAL;
-       }
 
        info->groups = devm_kzalloc(dev, info->ngroups *
                                            sizeof(struct rockchip_pin_group),
                                            GFP_KERNEL);
-       if (!info->groups) {
-               dev_err(dev, "failed allocate memory for ping group list\n");
+       if (!info->groups)
                return -EINVAL;
-       }
 
        i = 0;
 
@@ -2455,10 +2451,9 @@ static int rockchip_pinctrl_register(struct platform_device *pdev,
 
        pindesc = devm_kzalloc(&pdev->dev, sizeof(*pindesc) *
                        info->ctrl->nr_pins, GFP_KERNEL);
-       if (!pindesc) {
-               dev_err(&pdev->dev, "mem alloc for pin descriptors failed\n");
+       if (!pindesc)
                return -ENOMEM;
-       }
+
        ctrldesc->pins = pindesc;
        ctrldesc->npins = info->ctrl->nr_pins;