]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
soc: amlogic: add missing of_node_put()
authorwen yang <yellowriver2010@hotmail.com>
Tue, 5 Feb 2019 05:07:26 +0000 (05:07 +0000)
committerKevin Hilman <khilman@baylibre.com>
Thu, 7 Feb 2019 04:03:02 +0000 (20:03 -0800)
The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented here after the last
usage.

Signed-off-by: Wen Yang <yellowriver2010@hotmail.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Fixes: d4983983d987 ("soc: amlogic: add meson-canvas driver")
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
drivers/soc/amlogic/meson-canvas.c

index fce33ca76bb6285d94e2c838bf8aa560f2cbb04e..87a6c6e235912eb36b45d4c3db716eced46349f8 100644 (file)
@@ -57,9 +57,12 @@ struct meson_canvas *meson_canvas_get(struct device *dev)
                return ERR_PTR(-ENODEV);
 
        canvas_pdev = of_find_device_by_node(canvas_node);
-       if (!canvas_pdev)
+       if (!canvas_pdev) {
+               of_node_put(canvas_node);
                return ERR_PTR(-EPROBE_DEFER);
+       }
 
+       of_node_put(canvas_node);
        return dev_get_drvdata(&canvas_pdev->dev);
 }
 EXPORT_SYMBOL_GPL(meson_canvas_get);