]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
coresight: replicator: Fix missing spin_lock_init()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 18 Nov 2019 18:52:07 +0000 (11:52 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Nov 2019 18:18:15 +0000 (19:18 +0100)
The driver allocates the spinlock but not initialize it.
Use spin_lock_init() on it to initialize it correctly.

This is detected by Coccinelle semantic patch.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Tested-by: Yabin Cui <yabinc@google.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20191118185207.30441-3-mathieu.poirier@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/coresight/coresight-replicator.c

index 43304196a1a699a4b1f6b5d00ec841a3cb4bb011..e7dc1c31d20d4f215769291ba41eb5b5a7ef3164 100644 (file)
@@ -248,6 +248,7 @@ static int replicator_probe(struct device *dev, struct resource *res)
        }
        dev->platform_data = pdata;
 
+       spin_lock_init(&drvdata->spinlock);
        desc.type = CORESIGHT_DEV_TYPE_LINK;
        desc.subtype.link_subtype = CORESIGHT_DEV_SUBTYPE_LINK_SPLIT;
        desc.ops = &replicator_cs_ops;