]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
platform/x86: intel_ips: remove unnecessary checks in ips_debugfs_init
authorYueHaibing <yuehaibing@huawei.com>
Tue, 27 Nov 2018 03:09:38 +0000 (11:09 +0800)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 3 Dec 2018 19:40:03 +0000 (21:40 +0200)
As Greg KH explained in:
https://lkml.org/lkml/2015/8/15/114

There no need to check the return value of debugfs_create_file() and
debugfs_create_dir().

This also fix static code checker warnings:

drivers/platform/x86/intel_ips.c:1314
 ips_debugfs_init() warn: passing zero to 'PTR_ERR'
drivers/platform/x86/intel_ips.c:1328
 ips_debugfs_init() warn: passing zero to 'PTR_ERR'

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/intel_ips.c

index 225638a1b09e45d762668615cc9de93a0db100ba..f37c07c6ad8ea0c7364075da79eec76022e18c22 100644 (file)
@@ -1310,32 +1310,15 @@ static void ips_debugfs_init(struct ips_driver *ips)
        int i;
 
        ips->debug_root = debugfs_create_dir("ips", NULL);
-       if (!ips->debug_root) {
-               dev_err(ips->dev, "failed to create debugfs entries: %ld\n",
-                       PTR_ERR(ips->debug_root));
-               return;
-       }
 
        for (i = 0; i < ARRAY_SIZE(ips_debug_files); i++) {
-               struct dentry *ent;
                struct ips_debugfs_node *node = &ips_debug_files[i];
 
                node->ips = ips;
-               ent = debugfs_create_file(node->name, S_IFREG | S_IRUGO,
-                                         ips->debug_root, node,
-                                         &ips_debugfs_ops);
-               if (!ent) {
-                       dev_err(ips->dev, "failed to create debug file: %ld\n",
-                               PTR_ERR(ent));
-                       goto err_cleanup;
-               }
+               debugfs_create_file(node->name, S_IFREG | S_IRUGO,
+                                   ips->debug_root, node,
+                                   &ips_debugfs_ops);
        }
-
-       return;
-
-err_cleanup:
-       ips_debugfs_cleanup(ips);
-       return;
 }
 #endif /* CONFIG_DEBUG_FS */