]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iwlegacy: make const array static to shink object code size
authorColin Ian King <colin.king@canonical.com>
Thu, 21 Sep 2017 22:56:30 +0000 (23:56 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 25 Sep 2017 08:29:18 +0000 (11:29 +0300)
Don't populate const array ac_to_fifo on the stack in an inlined
function, instead make it static.  Makes the object code smaller
by over 800 bytes:

   text    data     bss     dec     hex filename
 159029   33154    1216  193399   2f377 4965-mac.o

   text    data     bss     dec     hex filename
 158122   33250    1216  192588   2f04c 4965-mac.o

(gcc version 7.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/intel/iwlegacy/4965-mac.c

index de9b6522c43f5dba3855c0b4e94f57dd4b3915c5..65eba2c24292e0653c21c4fc19431d404cc76eea 100644 (file)
@@ -1480,7 +1480,7 @@ il4965_get_ac_from_tid(u16 tid)
 static inline int
 il4965_get_fifo_from_tid(u16 tid)
 {
-       const u8 ac_to_fifo[] = {
+       static const u8 ac_to_fifo[] = {
                IL_TX_FIFO_VO,
                IL_TX_FIFO_VI,
                IL_TX_FIFO_BE,