]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: rtl8188eu: remove redundant assignment to variable rtstatus
authorColin Ian King <colin.king@canonical.com>
Wed, 31 Jul 2019 09:47:36 +0000 (10:47 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Jul 2019 11:37:13 +0000 (13:37 +0200)
Variable rtstatus is being initialized with a value that is never read
and rtstatus is being re-assigned a little later on. The assignment is
redundant and hence can be removed.  Also, make rtstatus a bool to
match the function return type.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20190731094736.28637-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/hal/bb_cfg.c

index 11e0bb9c67d75f0ce681b0a7861670ddcd47b2a0..51882858fcf0af3e55c60d2d30f5c950ae766e0f 100644 (file)
@@ -653,7 +653,7 @@ static bool config_parafile(struct adapter *adapt)
 
 bool rtl88eu_phy_bb_config(struct adapter *adapt)
 {
-       int rtstatus = true;
+       bool rtstatus;
        u32 regval;
        u8 crystal_cap;