]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
r8169: make use of phy_set_asym_pause
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 4 May 2019 10:01:03 +0000 (12:01 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 5 May 2019 17:49:48 +0000 (10:49 -0700)
phy_probe() takes care that all supported modes are advertised,
in addition use phy_support_asym_pause() to advertise pause modes.
This way we don't have to deal with phylib internals directly.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169.c

index 0ce3dcc6db267559830f2afaa75a8bb5a2d25b59..ee54648a3c6dfbb8ab25a85f0204443651f3bd12 100644 (file)
@@ -6451,8 +6451,7 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
        if (!tp->supports_gmii)
                phy_set_max_speed(phydev, SPEED_100);
 
-       /* Ensure to advertise everything, incl. pause */
-       linkmode_copy(phydev->advertising, phydev->supported);
+       phy_support_asym_pause(phydev);
 
        phy_attached_info(phydev);