]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
perf report: No need to have report_callchain_help as a global
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 28 May 2018 17:34:40 +0000 (14:34 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 4 Jun 2018 13:28:54 +0000 (10:28 -0300)
It is used in a single place, move the declaration to that function.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-p650ofrl8xike4dewxod51gg@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-report.c

index bc133e7a7ac26054c1eb3c8833be530927cd855d..cdb5b694983273de734fa1f45848c49eeac239d2 100644 (file)
@@ -946,12 +946,6 @@ parse_percent_limit(const struct option *opt, const char *str,
        return 0;
 }
 
-#define CALLCHAIN_DEFAULT_OPT  "graph,0.5,caller,function,percent"
-
-const char report_callchain_help[] = "Display call graph (stack chain/backtrace):\n\n"
-                                    CALLCHAIN_REPORT_HELP
-                                    "\n\t\t\t\tDefault: " CALLCHAIN_DEFAULT_OPT;
-
 int cmd_report(int argc, const char **argv)
 {
        struct perf_session *session;
@@ -960,6 +954,10 @@ int cmd_report(int argc, const char **argv)
        bool has_br_stack = false;
        int branch_mode = -1;
        bool branch_call_mode = false;
+#define CALLCHAIN_DEFAULT_OPT  "graph,0.5,caller,function,percent"
+       const char report_callchain_help[] = "Display call graph (stack chain/backtrace):\n\n"
+                                            CALLCHAIN_REPORT_HELP
+                                            "\n\t\t\t\tDefault: " CALLCHAIN_DEFAULT_OPT;
        char callchain_default_opt[] = CALLCHAIN_DEFAULT_OPT;
        const char * const report_usage[] = {
                "perf report [<options>]",