scsi: ufs: set the device reference clock setting

UFS host supplies the reference clock to UFS device and UFS device
specification allows host to provide one of the 4 frequencies (19.2 MHz, 26
MHz, 38.4 MHz, 52 MHz) for reference clock. Host should set the device
reference clock frequency setting in the device based on what frequency it
is supplying to UFS device.

Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
Reviewed-by: Evan Green <evgreen@chromium.org>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
index 2df00524bd2177fd2506f2ca7ad4efb59cf8aae5..8cf59452c675695a2d03e87646da4981a6db6a63 100644 (file)
--- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
+++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
@@ -33,6 +33,12 @@ Optional properties:
 - clocks                : List of phandle and clock specifier pairs
 - clock-names           : List of clock input name strings sorted in the same
                           order as the clocks property.
+                         "ref_clk" indicates reference clock frequency.
+                         UFS host supplies reference clock to UFS device and UFS device
+                         specification allows host to provide one of the 4 frequencies (19.2 MHz,
+                         26 MHz, 38.4 MHz, 52MHz) for reference clock. This "ref_clk" entry is
+                         parsed and used to update the reference clock setting in device.
+                         Defaults to 26 MHz(as per specification) if not specified by host.
 - freq-table-hz                : Array of <min max> operating frequencies stored in the same
                           order as the clocks property. If this property is not
                          defined or a value in the array is "0" then it is assumed

diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 58087d3916d05ef67268160ebe63b47eb59ddc54..8e4e52663a690739c407ddaf8437a01e55c0efcb 100644 (file)
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -378,6 +378,20 @@ enum query_opcode {
        UPIU_QUERY_OPCODE_TOGGLE_FLAG   = 0x8,
 };
 
+/* bRefClkFreq attribute values */
+enum ufs_ref_clk_freq {
+       REF_CLK_FREQ_19_2_MHZ   = 0,
+       REF_CLK_FREQ_26_MHZ     = 1,
+       REF_CLK_FREQ_38_4_MHZ   = 2,
+       REF_CLK_FREQ_52_MHZ     = 3,
+       REF_CLK_FREQ_INVAL      = -1,
+};
+
+struct ufs_ref_clk {
+       unsigned long freq_hz;
+       enum ufs_ref_clk_freq val;
+};
+
 /* Query response result code */
 enum {
        QUERY_RESULT_SUCCESS                    = 0x00,

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 23d7cca36ff031b6463aae8a639b061bfd2c825c..3807efd895beb700862953576231a1ba46cdb02f 100644 (file)
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -6699,6 +6699,74 @@ static void ufshcd_def_desc_sizes(struct ufs_hba *hba)
        hba->desc_size.hlth_desc = QUERY_DESC_HEALTH_DEF_SIZE;
 }
 
+static struct ufs_ref_clk ufs_ref_clk_freqs[] = {
+       {19200000, REF_CLK_FREQ_19_2_MHZ},
+       {26000000, REF_CLK_FREQ_26_MHZ},
+       {38400000, REF_CLK_FREQ_38_4_MHZ},
+       {52000000, REF_CLK_FREQ_52_MHZ},
+       {0, REF_CLK_FREQ_INVAL},
+};
+
+static enum ufs_ref_clk_freq
+ufs_get_bref_clk_from_hz(unsigned long freq)
+{
+       int i;
+
+       for (i = 0; ufs_ref_clk_freqs[i].freq_hz; i++)
+               if (ufs_ref_clk_freqs[i].freq_hz == freq)
+                       return ufs_ref_clk_freqs[i].val;
+
+       return REF_CLK_FREQ_INVAL;
+}
+
+void ufshcd_parse_dev_ref_clk_freq(struct ufs_hba *hba, struct clk *refclk)
+{
+       unsigned long freq;
+
+       freq = clk_get_rate(refclk);
+
+       hba->dev_ref_clk_freq =
+               ufs_get_bref_clk_from_hz(freq);
+
+       if (hba->dev_ref_clk_freq == REF_CLK_FREQ_INVAL)
+               dev_err(hba->dev,
+               "invalid ref_clk setting = %ld\n", freq);
+}
+
+static int ufshcd_set_dev_ref_clk(struct ufs_hba *hba)
+{
+       int err;
+       u32 ref_clk;
+       u32 freq = hba->dev_ref_clk_freq;
+
+       err = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_READ_ATTR,
+                       QUERY_ATTR_IDN_REF_CLK_FREQ, 0, 0, &ref_clk);
+
+       if (err) {
+               dev_err(hba->dev, "failed reading bRefClkFreq. err = %d\n",
+                       err);
+               goto out;
+       }
+
+       if (ref_clk == freq)
+               goto out; /* nothing to update */
+
+       err = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
+                       QUERY_ATTR_IDN_REF_CLK_FREQ, 0, 0, &freq);
+
+       if (err) {
+               dev_err(hba->dev, "bRefClkFreq setting to %lu Hz failed\n",
+                       ufs_ref_clk_freqs[freq].freq_hz);
+               goto out;
+       }
+
+       dev_dbg(hba->dev, "bRefClkFreq setting to %lu Hz succeeded\n",
+                       ufs_ref_clk_freqs[freq].freq_hz);
+
+out:
+       return err;
+}
+
 /**
  * ufshcd_probe_hba - probe hba to detect device and initialize
  * @hba: per-adapter instance
@@ -6764,6 +6832,12 @@ static int ufshcd_probe_hba(struct ufs_hba *hba)
                        "%s: Failed getting max supported power mode\n",
                        __func__);
        } else {
+               /*
+                * Set the right value to bRefClkFreq before attempting to
+                * switch to HS gears.
+                */
+               if (hba->dev_ref_clk_freq != REF_CLK_FREQ_INVAL)
+                       ufshcd_set_dev_ref_clk(hba);
                ret = ufshcd_config_pwr_mode(hba, &hba->max_pwr_info.info);
                if (ret) {
                        dev_err(hba->dev, "%s: Failed setting power mode, err = %d\n",
@@ -7250,6 +7324,14 @@ static int ufshcd_init_clocks(struct ufs_hba *hba)
                        goto out;
                }
 
+               /*
+                * Parse device ref clk freq as per device tree "ref_clk".
+                * Default dev_ref_clk_freq is set to REF_CLK_FREQ_INVAL
+                * in ufshcd_alloc_host().
+                */
+               if (!strcmp(clki->name, "ref_clk"))
+                       ufshcd_parse_dev_ref_clk_freq(hba, clki->clk);
+
                if (clki->max_freq) {
                        ret = clk_set_rate(clki->clk, clki->max_freq);
                        if (ret) {
@@ -8110,6 +8192,7 @@ int ufshcd_alloc_host(struct device *dev, struct ufs_hba **hba_handle)
        hba->host = host;
        hba->dev = dev;
        *hba_handle = hba;
+       hba->dev_ref_clk_freq = REF_CLK_FREQ_INVAL;
 
        INIT_LIST_HEAD(&hba->clk_list_head);
 

diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 1a1c2b487a4eb267a296a13d85344e3377bac763..69ba7445d2b3705556c441ceb84b7aeb964d18f2 100644 (file)
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -550,6 +550,7 @@ struct ufs_hba {
        void *priv;
        unsigned int irq;
        bool is_irq_enabled;
+       enum ufs_ref_clk_freq dev_ref_clk_freq;
 
        /* Interrupt aggregation support is broken */
        #define UFSHCD_QUIRK_BROKEN_INTR_AGGR                   0x1
@@ -768,6 +769,7 @@ void ufshcd_remove(struct ufs_hba *);
 int ufshcd_wait_for_register(struct ufs_hba *hba, u32 reg, u32 mask,
                                u32 val, unsigned long interval_us,
                                unsigned long timeout_ms, bool can_sleep);
+void ufshcd_parse_dev_ref_clk_freq(struct ufs_hba *hba, struct clk *refclk);
 
 static inline void check_upiu_size(void)
 {