]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: fsl: imx-spdif: consider CPU-Platform possibility
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 28 Jun 2019 01:47:30 +0000 (10:47 +0900)
committerMark Brown <broonie@kernel.org>
Fri, 28 Jun 2019 14:12:19 +0000 (15:12 +0100)
commit 014f07ca1cb12 ("ASoC: fsl: imx-spdif: don't select unnecessary
Platform")

Current ALSA SoC avoid to add duplicate component to rtd,
and this driver was selecting CPU component as Platform component.
Thus, above patch removed Platform settings from this driver,
because it assumed these are same component.

But, some CPU driver is using generic DMAEngine, in such case, both
CPU component and Platform component will have same of_node/name.
In other words, there are some components which are different but
have same of_node/name.

In such case, Card driver definitely need to select Platform even
though it is same as CPU.
It is depends on CPU driver, but is difficult to know it from Card driver.
This patch reverts above patch.

Fixes: commit 014f07ca1cb12 ("ASoC: fsl: imx-spdif: don't select unnecessary Platform")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/imx-spdif.c

index 393c5a31f494687a2f02e6955babf78bcb814e23..6c4dadf60355102b8b0eebab275f4088b41b6181 100644 (file)
@@ -26,7 +26,7 @@ static int imx_spdif_audio_probe(struct platform_device *pdev)
        }
 
        data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
-       comp = devm_kzalloc(&pdev->dev, 2 * sizeof(*comp), GFP_KERNEL);
+       comp = devm_kzalloc(&pdev->dev, 3 * sizeof(*comp), GFP_KERNEL);
        if (!data || !comp) {
                ret = -ENOMEM;
                goto end;
@@ -34,15 +34,18 @@ static int imx_spdif_audio_probe(struct platform_device *pdev)
 
        data->dai.cpus          = &comp[0];
        data->dai.codecs        = &comp[1];
+       data->dai.platforms     = &comp[2];
 
        data->dai.num_cpus      = 1;
        data->dai.num_codecs    = 1;
+       data->dai.num_platforms = 1;
 
        data->dai.name = "S/PDIF PCM";
        data->dai.stream_name = "S/PDIF PCM";
        data->dai.codecs->dai_name = "snd-soc-dummy-dai";
        data->dai.codecs->name = "snd-soc-dummy";
        data->dai.cpus->of_node = spdif_np;
+       data->dai.platforms->of_node = spdif_np;
        data->dai.playback_only = true;
        data->dai.capture_only = true;