]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: sh/fsi: Make one-bit bitfields unsigned
authorLars-Peter Clausen <lars@metafoo.de>
Thu, 19 Jun 2014 07:40:31 +0000 (09:40 +0200)
committerMark Brown <broonie@linaro.org>
Sat, 21 Jun 2014 20:02:08 +0000 (21:02 +0100)
One-bit signed bitfields have two possible values: 0 and -1. This sometimes
leads to unexpected results (e.g. foo.bar = 1; foo.bar == 1 => false) which is
why it is recommended to make one-bit bitfields unsigned.

This fixes the following sparse warnings:
sound/soc/sh/fsi.c:267:25: error: dubious one-bit signed bitfield
sound/soc/sh/fsi.c:268:22: error: dubious one-bit signed bitfield
sound/soc/sh/fsi.c:269:20: error: dubious one-bit signed bitfield
sound/soc/sh/fsi.c:270:28: error: dubious one-bit signed bitfield
sound/soc/sh/fsi.c:271:26: error: dubious one-bit signed bitfield
sound/soc/sh/fsi.c:272:25: error: dubious one-bit signed bitfield

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/sh/fsi.c

index 710a079a7377db8f9cf55422648242496fd97d07..2c95d85c69cb04a4b3ae7b851f922aec3df96d1a 100644 (file)
@@ -264,12 +264,12 @@ struct fsi_priv {
        u32 fmt;
 
        int chan_num:16;
-       int clk_master:1;
-       int clk_cpg:1;
-       int spdif:1;
-       int enable_stream:1;
-       int bit_clk_inv:1;
-       int lr_clk_inv:1;
+       unsigned int clk_master:1;
+       unsigned int clk_cpg:1;
+       unsigned int spdif:1;
+       unsigned int enable_stream:1;
+       unsigned int bit_clk_inv:1;
+       unsigned int lr_clk_inv:1;
 };
 
 struct fsi_stream_handler {