]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
NFC: pn533: mark expected switch fall-throughs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 13 Feb 2019 18:54:03 +0000 (12:54 -0600)
committerGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 9 Apr 2019 16:48:38 +0000 (11:48 -0500)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warnings:

drivers/nfc/pn533/pn533.c: In function ‘pn533_transceive’:
drivers/nfc/pn533/pn533.c:2142:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
      ^
drivers/nfc/pn533/pn533.c:2150:2: note: here
  default:
  ^~~~~~~
drivers/nfc/pn533/pn533.c: In function ‘pn533_wq_mi_recv’:
drivers/nfc/pn533/pn533.c:2267:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
      ^
drivers/nfc/pn533/pn533.c:2276:2: note: here
  default:
  ^~~~~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Addresses-Coverity-ID: 1230487 ("Missing break in switch")
Addresses-Coverity-ID: 1230488 ("Missing break in switch")
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
drivers/nfc/pn533/pn533.c

index a0cc1cc452927b54e84d749d053fe99e63463ca2..5961f14259e5eaaa987af1ff6a70bec34399ec63 100644 (file)
@@ -2147,6 +2147,7 @@ static int pn533_transceive(struct nfc_dev *nfc_dev,
 
                        break;
                }
+               /* fall through */
        default:
                /* jumbo frame ? */
                if (skb->len > PN533_CMD_DATAEXCH_DATA_MAXLEN) {
@@ -2273,6 +2274,7 @@ static void pn533_wq_mi_recv(struct work_struct *work)
 
                        break;
                }
+               /* fall through */
        default:
                skb_put_u8(skb, 1); /*TG*/