]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dmaengine: img-mdc: Remove unnecessary synchronize_irq() before devm_free_irq()
authorLars-Peter Clausen <lars@metafoo.de>
Sat, 21 Nov 2015 11:09:48 +0000 (12:09 +0100)
committerVinod Koul <vinod.koul@intel.com>
Sat, 5 Dec 2015 10:26:42 +0000 (15:56 +0530)
Calling synchronize_irq() right before devm_free_irq() is quite useless. On
one hand the IRQ can easily fire again before devm_free_irq() is entered,
on the other hand devm_free_irq() itself calls synchronize_irq() internally
(in a race condition free way), before any state associated with the IRQ is
freed.

Patch was generated using the following semantic patch:
// <smpl>
@@
expression irq, dev;
@@
-synchronize_irq(irq);
 devm_free_irq(dev, irq, ...);
// </smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/img-mdc-dma.c

index 9ca56830cc63d6d21dd3ea0c1961339680ff909c..42ae58d1e30309a835f1e5f66c4f90065a5cbd74 100644 (file)
@@ -979,7 +979,6 @@ static int mdc_dma_remove(struct platform_device *pdev)
                                 vc.chan.device_node) {
                list_del(&mchan->vc.chan.device_node);
 
-               synchronize_irq(mchan->irq);
                devm_free_irq(&pdev->dev, mchan->irq, mchan);
 
                tasklet_kill(&mchan->vc.task);