]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
stacktrace: Constify 'entries' arguments
authorBart Van Assche <bvanassche@acm.org>
Mon, 22 Jul 2019 18:24:41 +0000 (11:24 -0700)
committerIngo Molnar <mingo@kernel.org>
Thu, 25 Jul 2019 13:43:26 +0000 (15:43 +0200)
Make it clear to humans and to the compiler that the stack trace
('entries') arguments are not modified.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Waiman Long <longman@redhat.com>
Cc: Will Deacon <will.deacon@arm.com>
Link: https://lkml.kernel.org/r/20190722182443.216015-3-bvanassche@acm.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
include/linux/stacktrace.h
kernel/stacktrace.c

index f0cfd12cb45eb5e849e9e753cab8e9a701879719..83bd8cb475d7e5743d2cd9a3bf65e1a8e7591ac7 100644 (file)
@@ -9,9 +9,9 @@ struct task_struct;
 struct pt_regs;
 
 #ifdef CONFIG_STACKTRACE
-void stack_trace_print(unsigned long *trace, unsigned int nr_entries,
+void stack_trace_print(const unsigned long *trace, unsigned int nr_entries,
                       int spaces);
-int stack_trace_snprint(char *buf, size_t size, unsigned long *entries,
+int stack_trace_snprint(char *buf, size_t size, const unsigned long *entries,
                        unsigned int nr_entries, int spaces);
 unsigned int stack_trace_save(unsigned long *store, unsigned int size,
                              unsigned int skipnr);
index f5440abb753291df445a1ce17559fd476d810a15..6d1f68b7e528a3f48c97f0a1e5c1a572d8ed8e11 100644 (file)
@@ -20,7 +20,7 @@
  * @nr_entries:        Number of entries in the storage array
  * @spaces:    Number of leading spaces to print
  */
-void stack_trace_print(unsigned long *entries, unsigned int nr_entries,
+void stack_trace_print(const unsigned long *entries, unsigned int nr_entries,
                       int spaces)
 {
        unsigned int i;
@@ -43,7 +43,7 @@ EXPORT_SYMBOL_GPL(stack_trace_print);
  *
  * Return: Number of bytes printed.
  */
-int stack_trace_snprint(char *buf, size_t size, unsigned long *entries,
+int stack_trace_snprint(char *buf, size_t size, const unsigned long *entries,
                        unsigned int nr_entries, int spaces)
 {
        unsigned int generated, i, total = 0;