]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: pcm3168a: Fix serial mode dependent format support
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Tue, 15 Oct 2019 09:00:37 +0000 (12:00 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 15 Oct 2019 09:17:16 +0000 (10:17 +0100)
fmt 0 is perfectly valid (PCM3168A_FMT_I2S). Remove the return in case
fmt == 0.

Fixes: ("ASoC: pcm3168a: Use fixup instead of constraint for channels and formats")
Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20191015090037.23271-1-peter.ujfalusi@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/pcm3168a.c

index 708dac27fefffde7593d9149670f128868d8071e..313500ab36dfb46869a823be86b067cec410b351 100644 (file)
@@ -322,9 +322,6 @@ static void pcm3168a_update_fixup_pcm_stream(struct snd_soc_dai *dai)
        u64 formats = SNDRV_PCM_FMTBIT_S24_3LE | SNDRV_PCM_FMTBIT_S24_LE;
        unsigned int channel_max = dai->id == PCM3168A_DAI_DAC ? 8 : 6;
 
-       if (!pcm3168a->io_params[dai->id].fmt)
-               return;
-
        if (pcm3168a->io_params[dai->id].fmt == PCM3168A_FMT_RIGHT_J) {
                /* S16_LE is only supported in RIGHT_J mode */
                formats |= SNDRV_PCM_FMTBIT_S16_LE;