]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/amd/display: Debug print when validate_stream fails
authorHarry Wentland <harry.wentland@amd.com>
Thu, 7 Dec 2017 19:09:15 +0000 (14:09 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 19 Feb 2018 19:17:26 +0000 (14:17 -0500)
It might be good to understand why validate fails.

Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index da78ff495b539dd67795e80205d622180fc5dfd8..a7d8634d2df330b0aece03b823f8b9113b25fbb6 100644 (file)
@@ -2801,6 +2801,7 @@ int amdgpu_dm_connector_mode_valid(struct drm_connector *connector,
        /* TODO: Unhardcode stream count */
        struct dc_stream_state *stream;
        struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
+       enum dc_status dc_result = DC_OK;
 
        if ((mode->flags & DRM_MODE_FLAG_INTERLACE) ||
                        (mode->flags & DRM_MODE_FLAG_DBLSCAN))
@@ -2833,8 +2834,15 @@ int amdgpu_dm_connector_mode_valid(struct drm_connector *connector,
        stream->src.height = mode->vdisplay;
        stream->dst = stream->src;
 
-       if (dc_validate_stream(adev->dm.dc, stream) == DC_OK)
+       dc_result = dc_validate_stream(adev->dm.dc, stream);
+
+       if (dc_result == DC_OK)
                result = MODE_OK;
+       else
+               DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation\n",
+                             mode->vdisplay,
+                             mode->hdisplay,
+                             mode->clock);
 
        dc_stream_release(stream);