ALSA: line6: fix ifnullfree.cocci warnings

sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Andrej Krutak <dev@andree.sk>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c
index f9224ec141c89309363e4893b977d09bb4869749..c998667e98efd0f41ef04b44c06d8b48bbf3855f 100644 (file)
--- a/sound/usb/line6/driver.c
+++ b/sound/usb/line6/driver.c
@@ -480,8 +480,7 @@ static void line6_destruct(struct snd_card *card)
        /* Free buffer memory first. We cannot depend on the existence of private
         * data from the (podhd) module, it may be gone already during this call
         */
-       if (line6->buffer_message)
-               kfree(line6->buffer_message);
+       kfree(line6->buffer_message);
 
        kfree(line6->buffer_listen);