]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: nvec: check return value
authorXidong Wang <wangxidong_97@163.com>
Wed, 18 Dec 2019 05:56:38 +0000 (13:56 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Dec 2019 18:23:29 +0000 (19:23 +0100)
In nvec_kbd_probe(), the return value of devm_input_allocate_device()
should be checked before it is used.

Signed-off-by: Xidong Wang <wangxidong_97@163.com>
Link: https://lore.kernel.org/r/1576648598-12257-1-git-send-email-wangxidong_97@163.com
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/nvec/nvec_kbd.c

index 01dbb66f7e9a478b7c6eb77d4a8caa256f0fb639..386d619e3ee97a6e4dfb933138eaec07112c7b07 100644 (file)
@@ -123,6 +123,8 @@ static int nvec_kbd_probe(struct platform_device *pdev)
                keycodes[j++] = extcode_tab_us102[i];
 
        idev = devm_input_allocate_device(&pdev->dev);
+       if (!idev)
+               return -ENOMEM;
        idev->name = "nvec keyboard";
        idev->phys = "nvec";
        idev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP) | BIT_MASK(EV_LED);