]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/tegra: Delete an unnecessary check before the function call "vunmap"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 16 Jul 2016 05:23:42 +0000 (07:23 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 18 Jul 2016 07:11:30 +0000 (09:11 +0200)
The vunmap() function performs also input parameter validation.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/b3fbdcaf-1bda-7ce9-935b-2d716727ec39@users.sourceforge.net
drivers/gpu/drm/tegra/fb.c

index 1b12aa7a715e2eecd64232459366b4cafa8a8bff..e6d71fa4028eab234b57973bfe318c7259244377 100644 (file)
@@ -68,7 +68,7 @@ static void tegra_fb_destroy(struct drm_framebuffer *framebuffer)
                struct tegra_bo *bo = fb->planes[i];
 
                if (bo) {
-                       if (bo->pages && bo->vaddr)
+                       if (bo->pages)
                                vunmap(bo->vaddr);
 
                        drm_gem_object_unreference_unlocked(&bo->gem);