]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
nfsd: use true and false for boolean values
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 2 Aug 2018 00:44:05 +0000 (19:44 -0500)
committerJ. Bruce Fields <bfields@redhat.com>
Thu, 9 Aug 2018 20:11:21 +0000 (16:11 -0400)
Return statements in functions returning bool should use true or false
instead of an integer value.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfsfh.c

index a008e7634181a17001d995f3a20b5ac2a63e6cbf..b319080288c36c8f77dee284ea37db1b84aa3866 100644 (file)
@@ -451,7 +451,7 @@ static bool fsid_type_ok_for_exp(u8 fsid_type, struct svc_export *exp)
        switch (fsid_type) {
        case FSID_DEV:
                if (!old_valid_dev(exp_sb(exp)->s_dev))
-                       return 0;
+                       return false;
                /* FALL THROUGH */
        case FSID_MAJOR_MINOR:
        case FSID_ENCODE_DEV:
@@ -461,13 +461,13 @@ static bool fsid_type_ok_for_exp(u8 fsid_type, struct svc_export *exp)
        case FSID_UUID8:
        case FSID_UUID16:
                if (!is_root_export(exp))
-                       return 0;
+                       return false;
                /* fall through */
        case FSID_UUID4_INUM:
        case FSID_UUID16_INUM:
                return exp->ex_uuid != NULL;
        }
-       return 1;
+       return true;
 }