]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
misc: xilinx_sdfec: add missing __user annotation
authorLuc Van Oostenryck <luc.vanoostenryck@gmail.com>
Mon, 9 Dec 2019 21:37:19 +0000 (22:37 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jan 2020 14:16:51 +0000 (15:16 +0100)
The second arg of xsdfec_set_order() is a 'void __user *'
and this pointer is then used in get_user() which expect
a __user pointer.

But get_user() can't be used with a void pointer, it a
pointer to the effective type. This is done here by casting
the argument to a pointer to the effective type but the
__user is missing in the cast.

Fix this by adding the missing __user in the cast.

CC: Derek Kiernan <derek.kiernan@xilinx.com>
CC: Dragan Cvetic <dragan.cvetic@xilinx.com>
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Acked-by: Dragan Cvetic <dragan.cvetic@xilinx.com>
Link: https://lore.kernel.org/r/20191209213719.58037-1-luc.vanoostenryck@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/xilinx_sdfec.c

index 11835969e9828a6871791380ba26a7fbf349536a..f05e1b4c2826860c03417ec46d3cf465529ef585 100644 (file)
@@ -733,7 +733,7 @@ static int xsdfec_set_order(struct xsdfec_dev *xsdfec, void __user *arg)
        enum xsdfec_order order;
        int err;
 
-       err = get_user(order, (enum xsdfec_order *)arg);
+       err = get_user(order, (enum xsdfec_order __user *)arg);
        if (err)
                return -EFAULT;