]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
i2c: core: remove outdated DEBUG output
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 20 Sep 2018 16:14:20 +0000 (18:14 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Fri, 5 Oct 2018 16:12:43 +0000 (18:12 +0200)
The usefulness of this debug output is questionable. It covers only
direct i2c_transfer calls and no SMBUS calls, neither direct nor
emulated ones. And the latter one is largely used in the kernel, so a
lot of stuff is missed. False positives are also generated in case the
locking later fails. Also, we have a proper tracing mechanism for all
these kinds of transfers in place for years now. Remove this old one.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/i2c-core-base.c

index 9ee9a15e71347629d024709a17b9a6bb04fca8aa..c2b352c46faeb789e565c8024bbfd6010cd1db2d 100644 (file)
@@ -1940,16 +1940,6 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
         */
 
        if (adap->algo->master_xfer) {
-#ifdef DEBUG
-               for (ret = 0; ret < num; ret++) {
-                       dev_dbg(&adap->dev,
-                               "master_xfer[%d] %c, addr=0x%02x, len=%d%s\n",
-                               ret, (msgs[ret].flags & I2C_M_RD) ? 'R' : 'W',
-                               msgs[ret].addr, msgs[ret].len,
-                               (msgs[ret].flags & I2C_M_RECV_LEN) ? "+" : "");
-               }
-#endif
-
                if (in_atomic() || irqs_disabled()) {
                        ret = i2c_trylock_bus(adap, I2C_LOCK_SEGMENT);
                        if (!ret)