]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
qed: Correct doorbell configuration for !4Kb pages
authorRam Amrani <Ram.Amrani@cavium.com>
Tue, 9 May 2017 12:07:50 +0000 (15:07 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 May 2017 15:24:22 +0000 (11:24 -0400)
When configuring the doorbell DPI address, driver aligns the start
address to 4KB [HW-pages] instead of host PAGE_SIZE.
As a result, RoCE applications might receive addresses which are
unaligned to pages [when PAGE_SIZE > 4KB], which is a security risk.

Fixes: 51ff17251c9c ("qed: Add support for RoCE hw init")
Signed-off-by: Ram Amrani <Ram.Amrani@cavium.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_dev.c

index bb70522ad362e913dec2a8fadff5ab1fcc0f27b7..463927f17032cf8397823969221f32d884c54d85 100644 (file)
@@ -1370,7 +1370,7 @@ qed_hw_init_pf_doorbell_bar(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
                                                   NULL) +
                       qed_cxt_get_proto_cid_count(p_hwfn, PROTOCOLID_ETH,
                                                   NULL);
-       norm_regsize = roundup(QED_PF_DEMS_SIZE * non_pwm_conn, 4096);
+       norm_regsize = roundup(QED_PF_DEMS_SIZE * non_pwm_conn, PAGE_SIZE);
        min_addr_reg1 = norm_regsize / 4096;
        pwm_regsize = db_bar_size - norm_regsize;