]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mmc: tmio: Fix tuning flow
authorMasaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
Tue, 24 Jul 2018 14:51:37 +0000 (16:51 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 1 Aug 2018 10:02:03 +0000 (12:02 +0200)
If the return value of mmc_send_tuning() is error other than -EILSEQ,
the tuning fails and process goes out of for_loop. The correct
processing is to judge their TAP as not good (NG) and continue.

Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
[Niklas: update commit message]
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/tmio_mmc_core.c

index 416f9e078fda8b2491b52db17412a6b88222579d..72ac806e0c762d832b31f50ef7d6691b17948ff8 100644 (file)
@@ -818,8 +818,6 @@ static int tmio_mmc_execute_tuning(struct mmc_host *mmc, u32 opcode)
                        host->prepare_tuning(host, i % host->tap_num);
 
                ret = mmc_send_tuning(mmc, opcode, NULL);
-               if (ret && ret != -EILSEQ)
-                       goto out;
                if (ret == 0)
                        set_bit(i, host->taps);