]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
IB/core: Use __be32 for LIDs in opa_is_extended_lid
authorDon Hiatt <don.hiatt@intel.com>
Mon, 2 Oct 2017 18:04:33 +0000 (11:04 -0700)
committerDoug Ledford <dledford@redhat.com>
Wed, 4 Oct 2017 19:39:45 +0000 (15:39 -0400)
The LIDs passed to opa_extended_lid are in __be32 format,
change function signature accordingly.

This fixes the following sparse warnings:
  drivers/infiniband/core/cm.c:1181:60: warning: incorrect type in
argument 1 (different ba
  drivers/infiniband/core/cm.c:1182:60: warning: incorrect type in
argument 2 (different ba
  drivers/infiniband/core/cm.c:1242:68: warning: incorrect type in
argument 1 (different ba
  drivers/infiniband/core/cm.c:1243:68: warning: incorrect type in
argument 2 (different ba
  drivers/infiniband/core/cm.c:2922:66: warning: incorrect type in
argument 1 (different ba
  drivers/infiniband/core/cm.c:2923:66: warning: incorrect type in
argument 2 (different ba
  include/rdma/opa_addr.h:102:14: warning: cast to restricted __be32

Fixes: e92aa00a5189 ("IB/CM: Add OPA Path record support to CM")
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Don Hiatt <don.hiatt@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
include/rdma/opa_addr.h

index e6e90f18e6d5b6887fccb2b78d8f0c920cdb1edb..f68fca2966313002a216a1557428854f7ae22db3 100644 (file)
@@ -97,15 +97,15 @@ static inline u32 opa_get_lid_from_gid(const union ib_gid *gid)
  * @dlid: The DLID
  * @slid: The SLID
  */
-static inline bool opa_is_extended_lid(u32 dlid, u32 slid)
+static inline bool opa_is_extended_lid(__be32 dlid, __be32 slid)
 {
        if ((be32_to_cpu(dlid) >=
             be16_to_cpu(IB_MULTICAST_LID_BASE)) ||
            (be32_to_cpu(slid) >=
             be16_to_cpu(IB_MULTICAST_LID_BASE)))
                return true;
-       else
-               return false;
+
+       return false;
 }
 
 /* Get multicast lid base */