]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: seco-cec: Add a missing 'release_region()' in an error handling path
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 31 Aug 2019 06:42:58 +0000 (03:42 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 1 Oct 2019 19:41:21 +0000 (16:41 -0300)
At the beginning of the probe function, we have a call to
'request_muxed_region(BRA_SMB_BASE_ADDR, 7, "CEC00001")()'

A corresponding 'release_region()' is performed in the remove function but
is lacking in the error handling path.

Add it.

Fixes: b03c2fb97adc ("media: add SECO cec driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/seco-cec/seco-cec.c

index 9cd60fe1867c9a1c368d9a465cbdbb7bf3f7090c..a86b6e8f9196906ecd1c2eaeb8dc764d0a752e85 100644 (file)
@@ -675,6 +675,7 @@ static int secocec_probe(struct platform_device *pdev)
 err_delete_adapter:
        cec_delete_adapter(secocec->cec_adap);
 err:
+       release_region(BRA_SMB_BASE_ADDR, 7);
        dev_err(dev, "%s device probe failed\n", dev_name(dev));
 
        return ret;