]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
crypto: s5p-sss - fix AES support for Exynos5433
authorKamil Konieczny <k.konieczny@partner.samsung.com>
Fri, 1 Mar 2019 14:02:54 +0000 (15:02 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 7 Mar 2019 08:24:52 +0000 (16:24 +0800)
Commit 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
introduced bug in dereferencing clk_names[1] on platforms different from
Exynos5433. On Exynos board XU3 call trace is:

"Unable to handle kernel paging request at virtual address 00004000"
(strcmp) from [<c0774014>] (of_property_match_string+0x58/0xd0)
...
(devm_clk_get) from [<c075c248>] (s5p_aes_probe+0xd4/0x4a0)
(s5p_aes_probe) from [<c059dbc4>] (platform_drv_probe+0x6c/0xa4)

Fix this by setting array clk_names size to 2.

Fixes: 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/s5p-sss.c

index f4e625cf53cac3bd830b2ce3141cb2e971096608..1afdcb81d8ed1afba2b4ff72033758af46e44fef 100644 (file)
 struct samsung_aes_variant {
        unsigned int                    aes_offset;
        unsigned int                    hash_offset;
-       const char                      *clk_names[];
+       const char                      *clk_names[2];
 };
 
 struct s5p_aes_reqctx {