]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: netcp: remove the redundant memmov()
authorKaricheri, Muralidharan <m-karicheri2@ti.com>
Fri, 6 Jan 2017 20:37:40 +0000 (15:37 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sun, 8 Jan 2017 02:03:50 +0000 (21:03 -0500)
The psdata is populated with command data by netcp modules
to the tail of the buffer and set_words() copy the same
to the front of the psdata. So remove the redundant memmov
function call.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/netcp_core.c

index a136c56e0aff2e19611876fe8f2679881f9d1239..286fd8da3b67d6be72a8e4e7b531a8b7d05377be 100644 (file)
@@ -1226,9 +1226,9 @@ static int netcp_tx_submit_skb(struct netcp_intf *netcp,
                /* psdata points to both native-endian and device-endian data */
                __le32 *psdata = (void __force *)p_info.psdata;
 
-               memmove(p_info.psdata, p_info.psdata + p_info.psdata_len,
-                       p_info.psdata_len);
-               set_words(p_info.psdata, p_info.psdata_len, psdata);
+               set_words((u32 *)psdata +
+                         (KNAV_DMA_NUM_PS_WORDS - p_info.psdata_len),
+                         p_info.psdata_len, psdata);
                tmp |= (p_info.psdata_len & KNAV_DMA_DESC_PSLEN_MASK) <<
                        KNAV_DMA_DESC_PSLEN_SHIFT;
        }