]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iwlwifi: pcie: make array 'prop' static, shrinks object size
authorColin Ian King <colin.king@canonical.com>
Tue, 21 Aug 2018 10:21:09 +0000 (11:21 +0100)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 25 Jan 2019 18:57:18 +0000 (20:57 +0200)
Don't populate the array prop on the stack but instead make it static.
Makes the object code smaller by 30 bytes:

Before:
   text    data     bss     dec     hex filename
  80138   15382     576   96096   17760 drivers/net/wireless/intel/iwlwifi/pcie/trans.o

After:
   text    data     bss     dec     hex filename
  79948   15542     576   96066   17742 drivers/net/wireless/intel/iwlwifi/pcie/trans.o

(gcc version 8.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/pcie/trans.c

index f97aea5ffc44e4398754d020ef347238d387a3fb..dbe62bc3ece45e203146852973aaebc9c5ea3033 100644 (file)
@@ -1968,7 +1968,7 @@ static void iwl_trans_pcie_removal_wk(struct work_struct *wk)
        struct iwl_trans_pcie_removal *removal =
                container_of(wk, struct iwl_trans_pcie_removal, work);
        struct pci_dev *pdev = removal->pdev;
-       char *prop[] = {"EVENT=INACCESSIBLE", NULL};
+       static char *prop[] = {"EVENT=INACCESSIBLE", NULL};
 
        dev_err(&pdev->dev, "Device gone - attempting removal\n");
        kobject_uevent_env(&pdev->dev.kobj, KOBJ_CHANGE, prop);