]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: atlantic: broken link status on old fw
authorIgor Russkikh <irusskikh@marvell.com>
Mon, 6 Jan 2020 11:22:28 +0000 (14:22 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 6 Jan 2020 22:06:11 +0000 (14:06 -0800)
Last code/checkpatch cleanup did a copy paste error where code from
firmware 3 API logic was moved to firmware 1 logic.

This resulted in FW1.x users would never see the link state as active.

Fixes: 7b0c342f1f67 ("net: atlantic: code style cleanup")
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c

index 8910b62e67ed79d938696fedbe5a2a7eaf7bdc03..f547baa6c95499e5f16313ea47b2c04f18f105ca 100644 (file)
@@ -667,9 +667,7 @@ int hw_atl_utils_mpi_get_link_status(struct aq_hw_s *self)
        u32 speed;
 
        mpi_state = hw_atl_utils_mpi_get_state(self);
-       speed = mpi_state & (FW2X_RATE_100M | FW2X_RATE_1G |
-                            FW2X_RATE_2G5 | FW2X_RATE_5G |
-                            FW2X_RATE_10G);
+       speed = mpi_state >> HW_ATL_MPI_SPEED_SHIFT;
 
        if (!speed) {
                link_status->mbps = 0U;