]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
PCI: qcom: Fix pp->dev usage before assignment
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Tue, 25 Oct 2016 13:42:51 +0000 (14:42 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 26 Oct 2016 19:46:39 +0000 (14:46 -0500)
Initialize pp->dev in qcom_pcie_probe() before calling get_resources(),
which uses it.

[bhelgaas: changelog]
Fixes: e6a087eeaf91 ("PCI: qcom: Remove redundant struct qcom_pcie.dev")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/host/pcie-qcom.c

index ef0a84c7a5885e1d62df499353f1384d86a5fceb..35936409b2d45921a049db1d4ddcbc64c4bb8f04 100644 (file)
@@ -533,11 +533,11 @@ static int qcom_pcie_probe(struct platform_device *pdev)
        if (IS_ERR(pcie->phy))
                return PTR_ERR(pcie->phy);
 
+       pp->dev = dev;
        ret = pcie->ops->get_resources(pcie);
        if (ret)
                return ret;
 
-       pp->dev = dev;
        pp->root_bus_nr = -1;
        pp->ops = &qcom_pcie_dw_ops;