]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: dwc: Drop superfluous PCM preallocation error checks
authorTakashi Iwai <tiwai@suse.de>
Mon, 4 Feb 2019 15:38:20 +0000 (16:38 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 6 Feb 2019 17:28:59 +0000 (18:28 +0100)
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant.  Drop it.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/soc/dwc/dwc-pcm.c

index 2cc9632024fc39575a05b18d3385b449546c0cdb..a9ae91c4597f254794cc1ae582a236b0708941c8 100644 (file)
@@ -249,9 +249,10 @@ static int dw_pcm_new(struct snd_soc_pcm_runtime *rtd)
 {
        size_t size = dw_pcm_hardware.buffer_bytes_max;
 
-       return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
+       snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
                        SNDRV_DMA_TYPE_CONTINUOUS,
                        snd_dma_continuous_data(GFP_KERNEL), size, size);
+       return 0;
 }
 
 static void dw_pcm_free(struct snd_pcm *pcm)