]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/amd/display: Modify comments to match the code
authorZhan liu <zhan.liu@amd.com>
Mon, 25 Nov 2019 22:25:18 +0000 (17:25 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 26 Nov 2019 19:51:03 +0000 (14:51 -0500)
[Why]
This line of code was modified. However, comments
remained unchanged. As a result, comments and code are
mismatching.

[How]
Modifying comments to reflect code. At the same time,
explaining why the value was changed from 200ms to
3000ms.

Signed-off-by: Zhan Liu <zhan.liu@amd.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dc_helper.c

index 8da4576e2908de4b219224afe4a2ba57961697f5..e41befa067ce8440beebf542356a2812d6157427 100644 (file)
@@ -485,7 +485,12 @@ void generic_reg_wait(const struct dc_context *ctx,
                return;
        }
 
-       /* something is terribly wrong if time out is > 200ms. (5Hz) */
+       /*
+        * Something is terribly wrong if time out is > 3000ms.
+        * 3000ms is the maximum time needed for SMU to pass values back.
+        * This value comes from experiments.
+        *
+        */
        ASSERT(delay_between_poll_us * time_out_num_tries <= 3000000);
 
        for (i = 0; i <= time_out_num_tries; i++) {