]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/sti: use seq_puts to display a string
authorNicolas Iooss <nicolas.iooss_linux@m4x.org>
Fri, 31 Mar 2017 19:25:07 +0000 (21:25 +0200)
committerBenjamin Gaignard <benjamin.gaignard@linaro.org>
Tue, 9 May 2017 12:45:24 +0000 (14:45 +0200)
gdp_dbg_ctl() uses seq_printf() to display a color format name even
though there is no format string. When using -Wformat-string, gcc
reports the following warning:

    drivers/gpu/drm/sti/sti_gdp.c: In function 'gdp_dbg_ctl':
    drivers/gpu/drm/sti/sti_gdp.c:150:18: warning: format not a string
    literal and no format arguments [-Wformat-security]
        seq_printf(s, gdp_format_to_str[i].name);
                      ^~~~~~~~~~~~~~~~~

Silence this warning by using seq_puts() instead.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Link: http://patchwork.freedesktop.org/patch/msgid/20170331192507.20538-1-nicolas.iooss_linux@m4x.org
drivers/gpu/drm/sti/sti_gdp.c

index 88f16cdf6a4bcee03adc0c1145eaae317eb7d2ef..fd1a49437e76d4a6cca4197a112f4c563543d577 100644 (file)
@@ -149,7 +149,7 @@ static void gdp_dbg_ctl(struct seq_file *s, int val)
        seq_puts(s, "\tColor:");
        for (i = 0; i < ARRAY_SIZE(gdp_format_to_str); i++) {
                if (gdp_format_to_str[i].format == (val & 0x1F)) {
-                       seq_printf(s, gdp_format_to_str[i].name);
+                       seq_puts(s, gdp_format_to_str[i].name);
                        break;
                }
        }