net: hns3: Fix a misuse to devm_free_irq

we should use free_irq to free the nic irq during the unloading time.
because we use request_irq to apply it when nic up. It will crash if
up net device after reset the port. This patch fixes the issue.

Signed-off-by: qumingguang <qumingguang@huawei.com>
Signed-off-by: Lipeng <lipeng321@huawei.com>
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
index 39679fdb83c74f59fb4338b66f79a5282570f668..2a0af11c9b5993bc66363909bb2e93760bf4bf41 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
@@ -2558,9 +2558,8 @@ static int hns3_nic_uninit_vector_data(struct hns3_nic_priv *priv)
                        (void)irq_set_affinity_hint(
                                priv->tqp_vector[i].vector_irq,
                                                    NULL);
-                       devm_free_irq(&pdev->dev,
-                                     priv->tqp_vector[i].vector_irq,
-                                     &priv->tqp_vector[i]);
+                       free_irq(priv->tqp_vector[i].vector_irq,
+                                &priv->tqp_vector[i]);
                }
 
                priv->ring_data[i].ring->irq_init_flag = HNS3_VECTOR_NOT_INITED;