]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/prime: Unconditionally set up the prime file private
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 14 Jun 2019 20:35:20 +0000 (22:35 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 21 Jun 2019 09:48:09 +0000 (11:48 +0200)
It's tiny, already embedded, and setup/teardown cost is trivial.

Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190614203615.12639-5-daniel.vetter@ffwll.ch
drivers/gpu/drm/drm_file.c
drivers/gpu/drm/drm_gem.c

index 754af25fe25589fcf2fdf5f0ff5e8215b28fda33..ea34bc991858cf1270e997405e5f647a9e99c2dd 100644 (file)
@@ -147,8 +147,7 @@ struct drm_file *drm_file_alloc(struct drm_minor *minor)
        if (drm_core_check_feature(dev, DRIVER_SYNCOBJ))
                drm_syncobj_open(file);
 
-       if (drm_core_check_feature(dev, DRIVER_PRIME))
-               drm_prime_init_file_private(&file->prime);
+       drm_prime_init_file_private(&file->prime);
 
        if (dev->driver->open) {
                ret = dev->driver->open(dev, file);
@@ -159,8 +158,7 @@ struct drm_file *drm_file_alloc(struct drm_minor *minor)
        return file;
 
 out_prime_destroy:
-       if (drm_core_check_feature(dev, DRIVER_PRIME))
-               drm_prime_destroy_file_private(&file->prime);
+       drm_prime_destroy_file_private(&file->prime);
        if (drm_core_check_feature(dev, DRIVER_SYNCOBJ))
                drm_syncobj_release(file);
        if (drm_core_check_feature(dev, DRIVER_GEM))
@@ -253,8 +251,7 @@ void drm_file_free(struct drm_file *file)
        if (dev->driver->postclose)
                dev->driver->postclose(dev, file);
 
-       if (drm_core_check_feature(dev, DRIVER_PRIME))
-               drm_prime_destroy_file_private(&file->prime);
+       drm_prime_destroy_file_private(&file->prime);
 
        WARN_ON(!list_empty(&file->event_list));
 
index a8c4468f03d9166bd257f2bde65cbfbc7fe05ee5..e6c12c6ec728d53cd6cd6ae74893903369afa1a2 100644 (file)
@@ -254,8 +254,7 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
        else if (dev->driver->gem_close_object)
                dev->driver->gem_close_object(obj, file_priv);
 
-       if (drm_core_check_feature(dev, DRIVER_PRIME))
-               drm_gem_remove_prime_handles(obj, file_priv);
+       drm_gem_remove_prime_handles(obj, file_priv);
        drm_vma_node_revoke(&obj->vma_node, file_priv);
 
        drm_gem_object_handle_put_unlocked(obj);