]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging/olpc_dcon: Add drm conversion to TODO
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 28 May 2019 09:03:03 +0000 (11:03 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 13 Jun 2019 08:07:15 +0000 (10:07 +0200)
this driver is pretty horrible from a design pov, and needs a complete
overhaul. Concrete thing that annoys me is that it looks at
registered_fb, which is an internal thing to fbmem.c and fbcon.c. And
ofc it gets the lifetime rules all wrong (it should at least use
get/put_fb_info).

Looking at the history, there's been an attempt at dropping this from
staging in 2016, but that had to be reverted. Since then not real
effort except the usual stream of trivial patches, and fbdev has been
formally closed for any new hw support. Time to try again and drop
this?

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jens Frederich <jfrederich@gmail.com>
Cc: Daniel Drake <dsd@laptop.org>
Cc: Jon Nettleton <jon.nettleton@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190528090304.9388-33-daniel.vetter@ffwll.ch
drivers/staging/olpc_dcon/TODO

index 665a0b0617194b980656da59d693c2632261c80c..fe09efbc7f777a8c09a568db57cc5aeb5be6f36c 100644 (file)
@@ -1,4 +1,11 @@
 TODO:
+       - complete rewrite:
+         1. The underlying fbdev drivers need to be converted into drm kernel
+            modesetting drivers.
+         2. The dcon low-power display mode can then be integrated using the
+            drm damage tracking and self-refresh helpers.
+         This bolted-on self-refresh support that digs around in fbdev
+         internals, but isn't properly integrated, is not the correct solution.
        - see if vx855 gpio API can be made similar enough to cs5535 so we can
          share more code
        - convert all uses of the old GPIO API from <linux/gpio.h> to the