]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: wcd9335: add irqflag IRQF_ONESHOT flag
authorHariprasad Kelam <hariprasad.kelam@gmail.com>
Wed, 10 Jul 2019 02:16:27 +0000 (07:46 +0530)
committerMark Brown <broonie@kernel.org>
Mon, 22 Jul 2019 12:26:06 +0000 (13:26 +0100)
Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq
handler finished".

fixes below issue reported by coccicheck

sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Link: https://lore.kernel.org/r/20190710021627.GA13396@hari-Inspiron-1545
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wcd9335.c

index 1bbbe421b99983cef4ed5a51b25aef19f852220d..956602788d0e75ae152f3a885f1ea46dfb683c72 100644 (file)
@@ -4062,7 +4062,8 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
 
                ret = devm_request_threaded_irq(wcd->dev, irq, NULL,
                                                wcd9335_irqs[i].handler,
-                                               IRQF_TRIGGER_RISING,
+                                               IRQF_TRIGGER_RISING |
+                                               IRQF_ONESHOT,
                                                wcd9335_irqs[i].name, wcd);
                if (ret) {
                        dev_err(wcd->dev, "Failed to request %s\n",