]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ibmvnic: Correct goto target for tx irq initialization failure
authorNathan Fontenot <nfont@linux.vnet.ibm.com>
Tue, 20 Feb 2018 17:04:18 +0000 (11:04 -0600)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Feb 2018 20:35:18 +0000 (15:35 -0500)
When a failure occurs during initialization of the tx sub crq
irqs, we should branch to the cleanup of the tx irqs. The current
code branches to the rx irq cleanup and attempts to cleanup the
rx irqs which have not been initialized.

Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c

index ad0f9cc1be0498d16b37faa945c7e1a077d9225b..1703b881252f02b32459c3b350605ccba9df0904 100644 (file)
@@ -2620,7 +2620,7 @@ static int init_sub_crq_irqs(struct ibmvnic_adapter *adapter)
                        dev_err(dev, "Couldn't register tx irq 0x%x. rc=%d\n",
                                scrq->irq, rc);
                        irq_dispose_mapping(scrq->irq);
-                       goto req_rx_irq_failed;
+                       goto req_tx_irq_failed;
                }
        }