]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: dsa: sja1105: Fix bit offsets of index field from L2 lookup entries
authorVladimir Oltean <olteanv@gmail.com>
Sun, 2 Jun 2019 21:11:54 +0000 (00:11 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 4 Jun 2019 18:49:19 +0000 (11:49 -0700)
This was inadvertently copied from the SJA1105 E/T structure and not
tested.  Cross-checking with the P/Q/R/S documentation (UM11040) makes
it immediately obvious what the correct bit offsets for this field are.

Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/sja1105/sja1105_dynamic_config.c

index c981c12eb181dda9668c4a3eace2d88116dd9290..0023b03a010debbba44ea2cdc07fd3ecd59e3c1b 100644 (file)
@@ -62,7 +62,7 @@ sja1105pqrs_l2_lookup_cmd_packing(void *buf, struct sja1105_dyn_cmd *cmd,
         * such that our API doesn't need to ask for a full-blown entry
         * structure when e.g. a delete is requested.
         */
-       sja1105_packing(buf, &cmd->index, 29, 20,
+       sja1105_packing(buf, &cmd->index, 15, 6,
                        SJA1105PQRS_SIZE_L2_LOOKUP_ENTRY, op);
        /* TODO hostcmd */
 }