]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
RDMA/core: Fix a WARN() message
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 22 Feb 2019 06:29:02 +0000 (09:29 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Fri, 22 Feb 2019 18:53:37 +0000 (11:53 -0700)
The first parameter of WARN_ONCE() is a condition, then following
parameters are the message.  In this case, we left out the condition so it
will just print the ops->type string.

Fixes: 3856ec4b93c9 ("RDMA/core: Add RDMA_NLDEV_CMD_NEWLINK/DELLINK support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Majd Dibbiny <majd@mellanox.com>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/nldev.c

index 5e94dc87f04fd24e13a1ac5ce0293e42635d2901..11ed58d3fce59165ec414dfb478e67b658a6e512 100644 (file)
@@ -1222,10 +1222,8 @@ static const struct rdma_link_ops *link_ops_get(const char *type)
 void rdma_link_register(struct rdma_link_ops *ops)
 {
        down_write(&link_ops_rwsem);
-       if (link_ops_get(ops->type)) {
-               WARN_ONCE("Duplicate rdma_link_ops! %s\n", ops->type);
+       if (WARN_ON_ONCE(link_ops_get(ops->type)))
                goto out;
-       }
        list_add(&ops->list, &link_ops);
 out:
        up_write(&link_ops_rwsem);