]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
usb: gadget: udc: renesas_usb3: Fix b-device mode for "workaround"
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tue, 2 Oct 2018 11:57:44 +0000 (20:57 +0900)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Tue, 2 Oct 2018 12:16:52 +0000 (15:16 +0300)
If the "workaround_for_vbus" is true, the driver will not call
usb_disconnect(). So, since the controller keeps some registers'
value, the driver doesn't re-enumarate suitable speed after
the b-device mode is disabled. To fix the issue, this patch
adds usb_disconnect() calling in renesas_usb3_b_device_write()
if workaround_for_vbus is true.

Fixes: 43ba968b00ea ("usb: gadget: udc: renesas_usb3: add debugfs to set the b-device mode")
Cc: <stable@vger.kernel.org> # v4.14+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/udc/renesas_usb3.c

index e1656f361e081d398d8ab55820a00cf9497f3562..67d8a501d9944e5ca1d8335ad4c274592d5e9558 100644 (file)
@@ -2437,6 +2437,9 @@ static ssize_t renesas_usb3_b_device_write(struct file *file,
        else
                usb3->forced_b_device = false;
 
+       if (usb3->workaround_for_vbus)
+               usb3_disconnect(usb3);
+
        /* Let this driver call usb3_connect() anyway */
        usb3_check_id(usb3);