]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
RDMA/qedr: Fix rc initialization on CNQ allocation failure
authorKalderon, Michal <Michal.Kalderon@cavium.com>
Wed, 21 Mar 2018 12:51:51 +0000 (14:51 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 21 Mar 2018 20:38:41 +0000 (14:38 -0600)
Return code wasn't set properly when CNQ allocation failed.
This only affect error message logging, currently user will
receive an error message that says the qedr driver load failed
with rc '0', instead of ENOMEM

Fixes: ec72fce4 ("qedr: Add support for RoCE HW init")
Signed-off-by: Michal Kalderon <Michal.Kalderon@cavium.com>
Signed-off-by: Ariel Elior <Ariel.Elior@cavium.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/qedr/main.c

index db4bf97c0e156cdda65f09934bd48f7b0e4a5de4..0ffb9b93e22de4f81e0e192afb1fbc8b34f2e861 100644 (file)
@@ -833,7 +833,8 @@ static struct qedr_dev *qedr_add(struct qed_dev *cdev, struct pci_dev *pdev,
 
        dev->num_cnq = dev->ops->rdma_get_min_cnq_msix(cdev);
        if (!dev->num_cnq) {
-               DP_ERR(dev, "not enough CNQ resources.\n");
+               DP_ERR(dev, "Failed. At least one CNQ is required.\n");
+               rc = -ENOMEM;
                goto init_err;
        }