]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
tpm: replace symbolic permission with octal for securityfs files
authorNayna Jain <nayna@linux.vnet.ibm.com>
Mon, 14 Nov 2016 10:00:49 +0000 (05:00 -0500)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Sun, 27 Nov 2016 23:31:31 +0000 (01:31 +0200)
checkpatch.pl flags warning for symbolic permissions and suggests
to replace with octal value.

This patch changes securityfs pseudo files permission
to octal values in tpm_bios_log_setup().

Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/tpm_eventlog.c

index 42b49c4dff0194dfb18c909331adcec7b31b0eec..9467e316324a3dd9ff8fd4c9ec6dfdf1c4a990d4 100644 (file)
@@ -378,7 +378,7 @@ struct dentry **tpm_bios_log_setup(const char *name)
 
        bin_file =
            securityfs_create_file("binary_bios_measurements",
-                                  S_IRUSR | S_IRGRP, tpm_dir,
+                                  0440, tpm_dir,
                                   (void *)&tpm_binary_b_measurements_seqops,
                                   &tpm_bios_measurements_ops);
        if (is_bad(bin_file))
@@ -386,7 +386,7 @@ struct dentry **tpm_bios_log_setup(const char *name)
 
        ascii_file =
            securityfs_create_file("ascii_bios_measurements",
-                                  S_IRUSR | S_IRGRP, tpm_dir,
+                                  0440, tpm_dir,
                                   (void *)&tpm_ascii_b_measurements_seqops,
                                   &tpm_bios_measurements_ops);
        if (is_bad(ascii_file))