]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iio: dac: ad5380: fix incorrect assignment to val
authorColin Ian King <colin.king@canonical.com>
Thu, 15 Aug 2019 11:58:46 +0000 (12:58 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 3 Sep 2019 17:55:50 +0000 (18:55 +0100)
Currently the pointer val is being incorrectly incremented
instead of the value pointed to by val. Fix this by adding
in the missing * indirection operator.

Addresses-Coverity: ("Unused value")
Fixes: c03f2c536818 ("staging:iio:dac: Add AD5380 driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ad5380.c

index 4335214800d24f37559a8ba60c9d3e2af780f5bb..2ebe08326048954fab107ea442aca4bb54940464 100644 (file)
@@ -220,7 +220,7 @@ static int ad5380_read_raw(struct iio_dev *indio_dev,
                if (ret)
                        return ret;
                *val >>= chan->scan_type.shift;
-               val -= (1 << chan->scan_type.realbits) / 2;
+               *val -= (1 << chan->scan_type.realbits) / 2;
                return IIO_VAL_INT;
        case IIO_CHAN_INFO_SCALE:
                *val = 2 * st->vref;