]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
habanalabs: use do_div for 64-bit divisions
authorOded Gabbay <oded.gabbay@gmail.com>
Fri, 1 Mar 2019 12:21:11 +0000 (14:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Mar 2019 12:44:59 +0000 (13:44 +0100)
This patch fix compilation error in 32-bit ARM architecture regarding
division of 2 64-bit variables.

Use the kernel do_div() macro, which is implemented per architecture, for
doing these divisions instead of using the / operator.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/habanalabs/mmu.c

index ce404e6cc9a9b9c861d2019fa8b083da91f4e743..2f2e99cb27439433bd4527350b2347a6856cab5d 100644 (file)
@@ -261,9 +261,9 @@ int hl_mmu_ctx_init(struct hl_ctx *ctx)
                        !hdev->dram_default_page_mapping)
                return 0;
 
-       num_of_hop3 = (prop->dram_size_for_default_page_mapping /
-                       prop->dram_page_size) /
-                       PTE_ENTRIES_IN_HOP;
+       num_of_hop3 = prop->dram_size_for_default_page_mapping;
+       do_div(num_of_hop3, prop->dram_page_size);
+       do_div(num_of_hop3, PTE_ENTRIES_IN_HOP);
 
        /* add hop1 and hop2 */
        total_hops = num_of_hop3 + 2;
@@ -378,9 +378,9 @@ void hl_mmu_ctx_fini(struct hl_ctx *ctx)
        if (hdev->dram_supports_virtual_memory &&
                        hdev->dram_default_page_mapping) {
 
-               num_of_hop3 = (prop->dram_size_for_default_page_mapping /
-                               prop->dram_page_size) /
-                               PTE_ENTRIES_IN_HOP;
+               num_of_hop3 = prop->dram_size_for_default_page_mapping;
+               do_div(num_of_hop3, prop->dram_page_size);
+               do_div(num_of_hop3, PTE_ENTRIES_IN_HOP);
 
                /* add hop1 and hop2 */
                total_hops = num_of_hop3 + 2;