]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
xen/gntdev: switch from kcalloc() to kvcalloc()
authorJuergen Gross <jgross@suse.com>
Thu, 7 Nov 2019 11:15:46 +0000 (12:15 +0100)
committerJuergen Gross <jgross@suse.com>
Mon, 2 Dec 2019 06:39:23 +0000 (07:39 +0100)
With sufficient many pages to map gntdev can reach order 9 allocation
sizes. As there is no need to have physically contiguous buffers switch
to kvcalloc() in order to avoid failing allocations.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/xen/gntdev.c

index ad621ec1912c9064da777fe2693916cb7f590634..4fc83e3f5ad3d3ee838f7c03749db1855868a947 100644 (file)
@@ -112,14 +112,14 @@ static void gntdev_free_map(struct gntdev_grant_map *map)
                gnttab_free_pages(map->count, map->pages);
 
 #ifdef CONFIG_XEN_GRANT_DMA_ALLOC
-       kfree(map->frames);
+       kvfree(map->frames);
 #endif
-       kfree(map->pages);
-       kfree(map->grants);
-       kfree(map->map_ops);
-       kfree(map->unmap_ops);
-       kfree(map->kmap_ops);
-       kfree(map->kunmap_ops);
+       kvfree(map->pages);
+       kvfree(map->grants);
+       kvfree(map->map_ops);
+       kvfree(map->unmap_ops);
+       kvfree(map->kmap_ops);
+       kvfree(map->kunmap_ops);
        kfree(map);
 }
 
@@ -133,12 +133,13 @@ struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count,
        if (NULL == add)
                return NULL;
 
-       add->grants    = kcalloc(count, sizeof(add->grants[0]), GFP_KERNEL);
-       add->map_ops   = kcalloc(count, sizeof(add->map_ops[0]), GFP_KERNEL);
-       add->unmap_ops = kcalloc(count, sizeof(add->unmap_ops[0]), GFP_KERNEL);
-       add->kmap_ops  = kcalloc(count, sizeof(add->kmap_ops[0]), GFP_KERNEL);
-       add->kunmap_ops = kcalloc(count, sizeof(add->kunmap_ops[0]), GFP_KERNEL);
-       add->pages     = kcalloc(count, sizeof(add->pages[0]), GFP_KERNEL);
+       add->grants    = kvcalloc(count, sizeof(add->grants[0]), GFP_KERNEL);
+       add->map_ops   = kvcalloc(count, sizeof(add->map_ops[0]), GFP_KERNEL);
+       add->unmap_ops = kvcalloc(count, sizeof(add->unmap_ops[0]), GFP_KERNEL);
+       add->kmap_ops  = kvcalloc(count, sizeof(add->kmap_ops[0]), GFP_KERNEL);
+       add->kunmap_ops = kvcalloc(count,
+                                  sizeof(add->kunmap_ops[0]), GFP_KERNEL);
+       add->pages     = kvcalloc(count, sizeof(add->pages[0]), GFP_KERNEL);
        if (NULL == add->grants    ||
            NULL == add->map_ops   ||
            NULL == add->unmap_ops ||
@@ -157,8 +158,8 @@ struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count,
        if (dma_flags & (GNTDEV_DMA_FLAG_WC | GNTDEV_DMA_FLAG_COHERENT)) {
                struct gnttab_dma_alloc_args args;
 
-               add->frames = kcalloc(count, sizeof(add->frames[0]),
-                                     GFP_KERNEL);
+               add->frames = kvcalloc(count, sizeof(add->frames[0]),
+                                      GFP_KERNEL);
                if (!add->frames)
                        goto err;